Address feedback from @dsayling and @gmemstr in PR #47

* `error-sort` is by default set to an empty string * `--error-sort` is only invoked in the run step if a parameter is passed; otherwise, it is omitted Signed-off-by: Justin W. Flory (he/him) [UNICEF Innovation] <[email protected]>
CircleCI-Public · Nov 22, 2021 · 2ce2d29 · 2ce2d29
1 parent af35614
commit 2ce2d29
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/commands/html-proofer.yml b/src/commands/html-proofer.yml
@@ -68,9 +68,9 @@ parameters:
     type: boolean
     default: true
   error-sort:
-    description: "Defines the sort order for error output. Can be `:path`, `:desc`, or `:status` (default: `:path`)."
+    description: "Defines the sort order for error output. Can be `:path`, `:desc`, or `:status`."
     type: string
-    default: ''
+    default: "''"
   enforce-https:
     description: "Fails a link if it's not marked as `https` (default: `false`)."
     type: boolean
@@ -167,7 +167,7 @@ steps:
           --directory-index-file << parameters.directory-index-file >> \
           <<# parameters.disable-external >> --disable-external <</ parameters.disable-external >> \
           <<# parameters.empty-alt-ignore >> --empty-alt-ignore <</ parameters.empty-alt-ignore >> \
-          --error-sort << parameters.error-sort >> \
+          <<# parameters.error-sort >>--error-sort << parameters.error-sort >> <</ parameters.error-sort >> \
           <<# parameters.enforce-https >> --enforce-https <</ parameters.enforce-https >> \
           --extension << parameters.extension >> \
           <<# parameters.external_only >> --external_only <</ parameters.external_only >> \