Merge pull request #2 from yahehe/logging

Follow standard logging patterns and expect proper logger
Cimpress · Jun 19, 2017 · 65b1820 · 65b1820
2 parents 04ba67a + 79d73b4
commit 65b1820
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 4 deletions.
diff --git a/src/auth0V1.js b/src/auth0V1.js
@@ -6,7 +6,9 @@ const cache = require('./cache');
 
 // TODO: get from options
 const REFRESH_TOKEN_CLIENT_ID = process.env.DEFAULT_TARGET_ID || 'QkxOvNz4fWRFT6vcq79ylcIuolFz2cwN';
-let logger = console.log;
+let logger = process.env.NODE_DEBUG && process.env.NODE_DEBUG.includes('cimpress-auth0-client-request-promise')
+  ? console.log
+  : () => { };
 
 const generateAuthV1TokenCacheKey = config =>
   (config.clientId ? `${config.targetId}-${config.clientId}` : `${config.targetId}`);

diff --git a/src/auth0V2.js b/src/auth0V2.js
@@ -4,7 +4,9 @@ const request = require('request-promise');
 const cache = require('./cache');
 const auth0V1 = require('./auth0V1');
 
-let logger = console.log;
+let logger = process.env.NODE_DEBUG && process.env.NODE_DEBUG.includes('cimpress-auth0-client-request-promise')
+  ? console.log
+  : () => { };
 
 const generateAuthV2TokenCacheKey = (config, audience) => `${audience}-${config.clientId}`;
 

diff --git a/src/cache.js b/src/cache.js
@@ -10,7 +10,9 @@ const defaultCache = {
 
 let credentialCache = defaultCache;
 let keyGenFunc;
-let logger;
+let logger = process.env.NODE_DEBUG && process.env.NODE_DEBUG.includes('cimpress-auth0-client-request-promise')
+  ? console.log
+  : () => { };
 
 const parseCacheControlHeader = (headers) => {
   if (headers) {

diff --git a/src/passedInAuth.js b/src/passedInAuth.js
@@ -3,7 +3,9 @@ const _ = require('lodash');
 const auth0V2 = require('./auth0V2');
 const cache = require('./cache');
 
-let logger = console.log;
+let logger = process.env.NODE_DEBUG && process.env.NODE_DEBUG.includes('cimpress-auth0-client-request-promise')
+  ? console.log
+  : () => { };
 
 const makeRequest = (options, retryLoop) => {
   const requestOptions = _.assign({}, options);