Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid redundant builds on GH Actions #265

Merged
merged 10 commits into from
Mar 5, 2020
Merged

Avoid redundant builds on GH Actions #265

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
f2cdbab
Add stale builds canceller
vbuberen Mar 5, 2020
73aefa4
Add default repo token
vbuberen Mar 5, 2020
70c8928
typo fix
vbuberen Mar 5, 2020
9f97d16
Add stale builds canceller for pre merge checks
vbuberen Mar 5, 2020
d884ac5
Add filters
vbuberen Mar 5, 2020
372d2db
Add filters into pre-merge workflow
vbuberen Mar 5, 2020
e90d030
Update Gradle wrapper validation workflow
vbuberen Mar 5, 2020
5728f10
Update pre-merge workflow
vbuberen Mar 5, 2020
ac751cd
Update branches filtering
vbuberen Mar 5, 2020
71f4c8c
Update branches filtering pre merge
vbuberen Mar 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions .github/workflows/gradle-wrapper-validation.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,13 @@
name: Validate Gradle Wrapper
on: [push, pull_request]
on: pull_request
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually having also

on:
  push:
    branches:
      - develop
	  - release

Would be useful

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea is that we do have a run just after the merge on the develop and release branch so we're sure the HEAD is green.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was my next PR)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, so do you want to merge this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I just needed to get to the laptop to update this PR.
Now it is ready

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, feel free to merge as soon as it's ✅


jobs:
validation:
name: Validation
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: gradle/wrapper-validation-action@v1
- name: Checkout latest code
uses: actions/checkout@v2
- name: Validate Gradle Wrapper
uses: gradle/wrapper-validation-action@v1

6 changes: 3 additions & 3 deletions .github/workflows/pre-merge.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
name: Pre Merge Checks
on: [push, pull_request]
on: pull_request

jobs:
gradle:
runs-on: ubuntu-latest
steps:
- name: Checkout Repo
uses: actions/checkout@v2
- name: Run Gradle preMerge task
run: ./gradlew clean ktlintCheck lint detekt build test
- name: Run Gradle tasks
run: ./gradlew clean ktlintCheck lint detekt build test