Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSX CI Testing with Github Actions #3

Merged
merged 13 commits into from
May 21, 2020
Merged

OSX CI Testing with Github Actions #3

merged 13 commits into from
May 21, 2020

Conversation

ChrisKeefe
Copy link
Owner

This Draft PR has been opened to attempt to wire up Github Actions-based CI on OSX.

@thermokarst
Copy link

Go ahead and re-run the build:

https://github.com/ChrisKeefe/q2-diversity-lib/runs/696852971?check_suite_focus=true#step:4:1954

I forgot to update the tag on action-library-packaging, so your workflow checked out an older build.

@thermokarst
Copy link

Huzzah! It worked!

@thermokarst
Copy link

What's your plan for getting these changes back in into qiime2#6 ? Many of the errors in the test suite are because of missing data assets (you'll need to add them to package_data (link)).

@ChrisKeefe
Copy link
Owner Author

This PR is against bDiv, which is the 'from' branch of qiime2#6. Once tests are passing here, I was planning to squash these commits into that branch and carry on with my work there.

I've never tried to pull a PR into a branch with an open PR before - am I better off doing that on my local with an interactive rebase, then pushing up to bDiv directly?

@thermokarst
Copy link

I've never tried to pull a PR into a branch with an open PR before - am I better off doing that on my local with an interactive rebase, then pushing up to bDiv directly?

No, I think its 6 of one, half dozen of the other. I would just merge the PR, personally.

@ChrisKeefe
Copy link
Owner Author

ChrisKeefe commented May 21, 2020

Sweet! It looks as though this is working as expected. OSX build is failing (as expected) on the problematic test you caught earlier. I'm going to merge this sucker, remove the Travis config in a separate commit, and dig into that broken test. Thanks for all the support on this, @thermokarst!

@ChrisKeefe ChrisKeefe marked this pull request as ready for review May 21, 2020 17:23
@ChrisKeefe ChrisKeefe merged commit e1361c1 into bDiv May 21, 2020
ChrisKeefe added a commit that referenced this pull request May 28, 2020
@ChrisKeefe ChrisKeefe deleted the bDivGHosx branch November 30, 2020 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants