Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some missing names for macbook pro retina 2012 #75

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tolnaiz
Copy link

@tolnaiz tolnaiz commented Apr 22, 2019

No description provided.

@tolnaiz tolnaiz force-pushed the new_keys_for_macbook_pro_2012_retina branch from 94f874b to 232094a Compare April 22, 2019 09:22
@kossmoboleat
Copy link

kossmoboleat commented Aug 25, 2020

This site has a long list of SMC codes https://logi.wiki/index.php/SMC_Sensor_Codes

I'm not sure how the names were found/determined though. Seems like it's similar to the suggested changes, but not completely the same. iStat menus seems quite close to the above link, e.g. Key Th2H low 0 high 0 Left Fin Stack and "Fin Stack Left" in iStat menus. While this PR has "'NB/CPU/GPU HeatPipe 2 Proximity" which seems consistent with the existing "'NB/CPU/GPU HeatPipe 1 Proximity". Personally I'd prefer the left/right in the name, but I'm not sure what's better "Fin Stack" or "NB/CPU/GPU HeatPipe proximity"...

Screen Shot 2020-08-25 at 10 17 32

@tolnaiz
Copy link
Author

tolnaiz commented Aug 25, 2020

This site has a long list of SMC codes https://logi.wiki/index.php/SMC_Sensor_Codes

I'm not sure how the names were found/determined though. Seems like it's similar to the suggested changes, but not completely the same. iStat menus seems quite close to the above link, e.g. Key Th2H low 0 high 0 Left Fin Stack and "Fin Stack Left" in iStat menus. While this PR has "'NB/CPU/GPU HeatPipe 2 Proximity" which seems consistent with the existing "'NB/CPU/GPU HeatPipe 1 Proximity". Personally I'd prefer the left/right in the name, but I'm not sure what's better "Fin Stack" or "NB/CPU/GPU HeatPipe proximity"...

"Left" and "Right" would be definitely better, if Apple wouldn't mix Th2H and Th1H across the different models according to the wiki. (Th2H is usually the right one, but sometimes it's the left one.) Althought it seems like they are using the same convention on newer models. Honestly I don't know what would be the best solution for this.

I think Fin Stack is much better. Maybe I just followed iStat menu's terminology when I created the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants