-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Dockerfile to get the tokens #35
Conversation
Hey @DavidDeSloovere , thanks a lot for your PR! It sounds really great and I appreciate the time and effort you put into this. |
@maartenhendrix : do you think you could give me a help here, if you want and can? |
I'm not sure if I can. Also not near a computer for some time 😬 |
Update for latest version. |
Hey @DavidDeSloovere thanks for updating this!
|
Only 1 In Had merge conflicts on readme, I can work with git (somewhat), but not experienced with github flow, forks etc... so hope I didn't make it worse. |
LGTM, it would be nice to add a pre-built docker image. |
On another project I have a GH action that builds and uploads the image into the artifacts of the repo. Might be better in a separate PR. |
Agreed, merged as first version. |
Hey everyone, Edit: |
#33
Most of this is generated. Readme got automatically formatted after I changed the content.
I was able to build and the container successfully in VS Code.
The next step would be to build the container in a Github action a publish it to either your repo's Artifacts or official Docker hub. I have done that recently in my own project.
I wonder if this should go into a separate repo.