Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add user agent video stats #6871

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

kontrollanten
Copy link
Contributor

@kontrollanten kontrollanten commented Feb 3, 2025

Description

Add video stats dividing viewers into:

  • Device family
  • OS family
  • Browser family

Todo:

  • Add tests
  • Add hook to parse user agent strings

Since the current used useragent lib couldn't distinguish between Edge and Chrome I used ua-parser-js instead.

Related issues

closes #6832

Has this been tested?

  • 👍 yes, I added tests to the test suite

Screenshots

image
image
image

Copy link

socket-security bot commented Feb 3, 2025

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

@kontrollanten kontrollanten force-pushed the feat-6832-user-agent-stats branch from d09b308 to 12553d7 Compare February 6, 2025 22:59
@kontrollanten kontrollanten force-pushed the feat-6832-user-agent-stats branch from 12553d7 to 4dd7198 Compare February 6, 2025 23:02
Copy link

Report too large to display inline

View full report↗︎

@kontrollanten kontrollanten changed the title WIP: add user agent video stats add user agent video stats Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant