Info: Rewrite document to table-style #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is mostly a translation of Hodor's description (it seemed pretty close to current document in wording). Sources used: - Main: https://xgm.guru/p/wc3/w3-file-format - https://www.wc3maps.com/InsideTheW3M.html - https://github.com/stijnherfst/HiveWE/wiki/war3map.w3i---Map-Info Potential sources: - Not available there: https://github.com/inwc3/wc3libs/tree/master/wc3libs_doc/src/specs/bin - https://www.hiveworkshop.com/threads/parsing-metadata-from-w3m-w3x-w3n.322007/ - https://www.hiveworkshop.com/threads/list-of-official-patches-for-warcraft-3.322919/
|
Here're the CSV files I've worked with and then converted to Markdown tables with https://www.tablesgenerator.com/markdown_tables After this gets merged, the master copy will become the .md document here. wc3i.csv |
|
@ChiefOfGxBxL hey do you have time to review and accept the PR? If not, I will continue with changes in my fork. |
ChiefOfGxBxL
approved these changes
Nov 8, 2022
|
@Luashine My apologies for the delay. I've reviewed the changes and approved them! Great job and thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's part of my #3 proposal. Please tell me what you think, then I will improve formatting before merging. Some table cells would love some line breaks!
If it's alright, I will continue with the other documents.
I've also noted that the old description seemed to be actually wrong in a few places around the middle of the spec. I had implemented a parser around Hodor's description earlier so I'm pretty confident it is correct. Not that I explored any advnced features like item tables...
I've included other links (all that I know of) to cross-check, if anyone's interested.
It is mostly a translation of Hodor's description (it seemed pretty
close to current document in wording).
Sources used:
Potential sources: