Added sync & callback interface to KINETIS/GPIOv1. #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twadleigh
force-pushed
the
twadleigh/pal-with-events
branch
from
46efa7d to
47b1725
Compare
|
Would you mind creating/updating a testhal app for this? |
|
Any time to look into it? |
|
I should be able to get back to this in the next couple of weeks. |
|
Any update? |
|
No. My project ended up moving to arduino, which is the platform for which my MC has proper support. I'm unsure when I will have the time to get back to this now. |
fpoussin
approved these changes
Aug 18, 2020
|
Merged, I'll try to add a testhal when I have some free time. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added an implementation for the synchronous and callback interface extensions to the PAL interface for the KINETIS boards. I stole as much as I could from
KINETIS/LLD/PORTv1. The implementation compiles against my qmk_firmware project, but hasn't been tested in any other sense.I would very much appreciate a careful code review from someone with more chbios experience than I have.