[CHIA-1087] remove the ANALYZE_SPENDS flag
#718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lock validation, we can remove the ANALYZE_SPENDS flag. It's implied for validate_clvm_and_signature()
Pull Request Test Coverage Report for Build 10994391298Details
💛 - Coveralls |
Rigidity
approved these changes
Sep 23, 2024
AmineKhaldi
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
now that the mempool TX validation path has been separated from the block validation, we can remove the
ANALYZE_SPENDSflag. It's implied forvalidate_clvm_and_signature().This, further, lets us remove the
SpendVisitorgeneric parameter torun_block_generator()andrun_block_generator2().With this PR Chia-Network/chia-blockchain#18557 we have separated the mempool TX validation path from the block validation path. This is why we can now further simplify the block validation path.