Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include byte cost in return value from get_conditions_from_spendbundle() #679

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented Aug 26, 2024

the byte cost was not included in the returned cost field, but it's supposed to be

@arvidn arvidn requested a review from matt-o-how August 26, 2024 22:34
@arvidn arvidn marked this pull request as ready for review August 26, 2024 22:40
@Rigidity
Copy link
Contributor

Ah nice, I was wondering whether this was intentional or not

@arvidn arvidn force-pushed the get_conditions_from_spendbundle branch from bebf04d to 274884c Compare August 27, 2024 00:13
@arvidn arvidn force-pushed the get_conditions_from_spendbundle branch from 274884c to 29ea8d7 Compare August 27, 2024 07:15
Copy link

Pull Request Test Coverage Report for Build 10573471380

Details

  • 9 of 10 (90.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 83.891%

Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/chia-consensus/src/spendbundle_validation.rs 4 5 80.0%
Totals Coverage Status
Change from base Build 10422144649: 0.01%
Covered Lines: 12301
Relevant Lines: 14663

💛 - Coveralls

@arvidn arvidn merged commit e032f9d into main Aug 27, 2024
59 checks passed
@arvidn arvidn deleted the get_conditions_from_spendbundle branch August 27, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants