fix return type of get_hash() in python binding
#664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arvidn
force-pushed
the
get_hash-py-binding
branch
from
25cfb6d to
42e45db
Compare
…eturn a plain bytes object. This fixes it by actually constructing a bytes32 object to be returned. Also extend the built-in conversion to also support bytes48
arvidn
force-pushed
the
get_hash-py-binding
branch
from
42e45db to
928e607
Compare
Rigidity
approved these changes
Aug 14, 2024
Pull Request Test Coverage Report for Build 10395046680Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
even though the type stub for get_hash() says bytes32 we currently return a plain bytes object. This fixes it by actually constructing a bytes32 object to be returned. Also extend the built-in conversion to also support bytes48