Add MerkleSet struct to Rust #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-o-how
force-pushed
the
merkle_vec_rebased
branch
from
d0256da to
5191ab9
Compare
arvidn
requested changes
Apr 4, 2024
matt-o-how
force-pushed
the
merkle_vec_rebased
branch
from
5191ab9 to
c4041df
Compare
Pull Request Test Coverage Report for Build 8752430900Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Rigidity
reviewed
Apr 9, 2024
arvidn
requested changes
Apr 10, 2024
arvidn
reviewed
Apr 10, 2024
arvidn
reviewed
Apr 10, 2024
arvidn
reviewed
Apr 12, 2024
- also removes async requirements
matt-o-how
force-pushed
the
merkle_vec_rebased
branch
from
3521feb to
e403fff
Compare
…ree (and hashes) doesn't include them. Likewise, when parsing proofs, collapse such redundant empty nodes
…n collapsed trees, but proofs produce complete trees
generate proofs that include redundant empty nodes
improvements to Merkle tests
…ed a correct looking proof
Add leaf audit to proof deserialization
add tests for generating non-collapsed proofs
…tches the existing python name
rename get_merkle_root() -> get_root()
…ngs compared to chia-blockchain
Merkle set from blockchain
arvidn
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also includes Python bindings and tests for Rust and Python