Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose bytes32 as the right type, from chia-blockchain #401

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented Feb 14, 2024

Now that we have the infrastructure to have these custom conversions, we might as well do it for bytes32 as well.
This addresses a lot of risks when using these types in chia-blockchain, as we don't have test coverage for all places we print bytes32 objects for instance.

Copy link

Pull Request Test Coverage Report for Build 7900076240

Details

  • -1 of 5 (80.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 84.932%

Changes Missing Coverage Covered Lines Changed/Added Lines %
chia-protocol/src/bytes.rs 4 5 80.0%
Totals Coverage Status
Change from base Build 7877262781: -0.003%
Covered Lines: 11301
Relevant Lines: 13306

💛 - Coveralls

@arvidn arvidn merged commit aae2708 into main Feb 14, 2024
64 checks passed
@arvidn arvidn deleted the bytes32 branch February 14, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants