Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose integers as our fixed-width integer types from chia-blockchain #378

Closed
wants to merge 1 commit into from

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented Jan 29, 2024

this makes integration of rust types (more) seamless in chia-blockchain, and greatly simplifies the patches to transition types. No longer requiring explicit casts to the fixed width integer types

@arvidn arvidn force-pushed the python-bindings-int branch from 98d996c to 9c87ac3 Compare January 29, 2024 16:02
@arvidn arvidn requested a review from Rigidity January 29, 2024 16:06
@arvidn arvidn marked this pull request as ready for review January 29, 2024 16:06
Copy link

coveralls-official bot commented Jan 29, 2024

Pull Request Test Coverage Report for Build 7702177520

  • -19 of 65 (70.77%) changed or added relevant lines in 6 files are covered.
  • 7 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.02%) to 84.704%

Changes Missing Coverage Covered Lines Changed/Added Lines %
chia-protocol/src/unfinished_block.rs 0 2 0.0%
chia_py_streamable_macro/src/lib.rs 27 32 84.38%
chia-protocol/src/fullblock.rs 0 6 0.0%
chia-protocol/src/header_block.rs 0 6 0.0%
Files with Coverage Reduction New Missed Lines %
chia-protocol/src/unfinished_block.rs 1 32.43%
chia-protocol/src/fullblock.rs 3 16.67%
chia-protocol/src/header_block.rs 3 27.16%
Totals Coverage Status
Change from base Build 7655434740: 0.02%
Covered Lines: 11136
Relevant Lines: 13147

💛 - Coveralls

Rigidity
Rigidity previously approved these changes Jan 29, 2024
Copy link
Contributor

@Rigidity Rigidity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would love to not require importing chia-blockchain anywhere in this repo, but we're already doing so. In the future I think it might be a good idea to implement the sized int types directly in Rust. But this is good for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants