-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update trait impls and conversions for byte types #372
Conversation
Pull Request Test Coverage Report for Build 7626926267Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, just a few comments and questions
This PR adds missing conversions for
Bytes
,BytesImpl
, andProgram
, and removesPartialEq
implementations for other types to reduce complexity.It also changes
From
toTryFrom
in some cases where the conversion is fallible:https://doc.rust-lang.org/std/convert/trait.From.html