Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate metric for operator errors #178

Merged
merged 2 commits into from
Sep 12, 2024
Merged

Conversation

Starttoaster
Copy link
Contributor

When reviewing the metrics endpoint of the operator, I discovered there's a metric that is automatically created by controller-runtime to count errors for a particular controller. This is way more useful than this manually collected metric for the operator as a whole.

# HELP controller_runtime_terminal_reconcile_errors_total Total number of terminal reconciliation errors per controller
# TYPE controller_runtime_terminal_reconcile_errors_total counter
controller_runtime_terminal_reconcile_errors_total{controller="chiaca"} 0
controller_runtime_terminal_reconcile_errors_total{controller="chiacrawler"} 0
controller_runtime_terminal_reconcile_errors_total{controller="chiafarmer"} 0
controller_runtime_terminal_reconcile_errors_total{controller="chiaharvester"} 0
controller_runtime_terminal_reconcile_errors_total{controller="chiaintroducer"} 0
controller_runtime_terminal_reconcile_errors_total{controller="chianode"} 0
controller_runtime_terminal_reconcile_errors_total{controller="chiaseeder"} 0
controller_runtime_terminal_reconcile_errors_total{controller="chiatimelord"} 0
controller_runtime_terminal_reconcile_errors_total{controller="chiawallet"} 0

@Starttoaster Starttoaster marked this pull request as ready for review September 12, 2024 20:06
@Starttoaster Starttoaster merged commit feefbcc into main Sep 12, 2024
11 checks passed
@Starttoaster Starttoaster deleted the remove-dupe-metric branch September 12, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants