Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

address issue introduced in #19207 #19328

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

address issue introduced in #19207 #19328

wants to merge 1 commit into from

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented Feb 27, 2025

where empty transaction blocks would not have None transactions_block_generator

Purpose:

Current Behavior:

New Behavior:

Testing Notes:

@arvidn
address issue introduced in #19207 where empty transaction blocks wou…
3d6138d 
…ld not have None transactions_block_generator
@arvidn arvidn requested a review from a team as a code owner February 27, 2025 00:12
@arvidn arvidn requested a review from emlowe February 27, 2025 00:12
@arvidn arvidn added the Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog label Feb 27, 2025
wjblanke
wjblanke approved these changes Feb 27, 2025
View reviewed changes
Copy link
Contributor

@wjblanke wjblanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aok

@github-actions GitHub Actions
Copy link
Contributor

File Coverage Missing Lines
chia/full_node/full_node_api.py 66.7% lines 870
Total Missing Coverage
8 lines Unknown 87%

altendky
altendky requested changes Feb 27, 2025
View reviewed changes
Copy link
Contributor

@altendky altendky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

discussing the coverage report

@arvidn
Copy link
Contributor Author

arvidn commented Feb 28, 2025

@almogdepaz is working on test coverage for this function. I believe we've never had a unit test for it

@emlowe
Copy link
Contributor

emlowe commented Feb 28, 2025

Arvid, is the plan to add coverage in a separate PR? (I remove the coverage flag assuming a separate PR was the plan, but perhaps I was hasty to do so)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@altendky altendky altendky requested changes

@wjblanke wjblanke wjblanke approved these changes

@emlowe emlowe emlowe approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arvidn @emlowe @altendky @wjblanke