Add increment to skipped_items if we hit an Exception in mempool #19286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-o-how
added
the
Changed
github-actions
bot
added
the
merge_conflict
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
matt-o-how
force-pushed
the
add_skip_to_exception
branch
from
2f84a72 to
41620dd
Compare
github-actions
bot
removed
the
merge_conflict
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
Pull Request Test Coverage Report for Build 13412912353Details
💛 - Coveralls |
matt-o-how
force-pushed
the
add_skip_to_exception
branch
from
b458ce9 to
60dd958
Compare
AmineKhaldi
reviewed
Feb 28, 2025
| @@ -3176,7 +3176,7 @@ def agg_and_add_sb_returning_cost_info(mempool: Mempool, spend_bundles: list[Spe | |||
| # The 3 items got skipped here | |||
| # We ran with solution A and missed bigger savings on solution B | |||
| assert mempool.size() == 5 | |||
| assert [c.coin for c in agg.coin_spends] == [coins[0], coins[1], coins[2]] | |||
| assert [c.coin for c in agg.coin_spends] == [coins[0], coins[1]] | |||
There was a problem hiding this comment.
Do we know exactly how the fix led to this test change?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose:
If we hit an exception in the mempool items we skip that item, this change means that we track this correctly.