Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHIA-2369] Legacy-ify DAOs #19266

Merged
merged 1 commit into from
Feb 20, 2025
Merged

[CHIA-2369] Legacy-ify DAOs #19266

merged 1 commit into from
Feb 20, 2025

Conversation

Quexington
Copy link
Contributor

The DAO wallet was not launched very successfully and is not in use as far as we can tell. It also adds a lot of surface area to the wallet which creates instability as well as resistance to refactoring.

This PR deletes all usage of DAO concepts in order to mitigate these concerns.

@Quexington Quexington changed the title Legacy-ify DAOs [2369] Legacy-ify DAOs Feb 14, 2025
@Quexington Quexington changed the title [2369] Legacy-ify DAOs [CHIA-2369] Legacy-ify DAOs Feb 14, 2025
@Quexington Quexington added 1.6.0 Changed Required label for PR that categorizes merge commit message as "Changed" for changelog and removed 1.6.0 labels Feb 14, 2025
Copy link
Contributor

File Coverage Missing Lines
chia/cmds/wallet_funcs.py 0.0% lines 118
Total Missing Coverage
5 lines Unknown 80%

Copy link

Pull Request Test Coverage Report for Build 13319525038

Details

  • 4 of 5 (80.0%) changed or added relevant lines in 2 files are covered.
  • 65 unchanged lines in 20 files lost coverage.
  • Overall coverage decreased (-0.4%) to 91.144%

Changes Missing Coverage Covered Lines Changed/Added Lines %
chia/cmds/wallet_funcs.py 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
chia/daemon/client.py 1 74.16%
chia/daemon/keychain_proxy.py 1 73.24%
chia/daemon/server.py 1 83.46%
chia/farmer/farmer.py 1 73.37%
chia/full_node/full_node.py 1 86.08%
chia/_tests/simulation/test_simulation.py 1 96.45%
chia/_tests/util/time_out_assert.py 1 98.29%
chia/util/condition_tools.py 1 90.52%
chia/util/streamable.py 1 98.93%
chia/wallet/util/wallet_sync_utils.py 1 86.14%
Totals Coverage Status
Change from base Build 13291657602: -0.4%
Covered Lines: 100457
Relevant Lines: 110060

💛 - Coveralls

@Quexington Quexington marked this pull request as ready for review February 17, 2025 21:29
@Quexington Quexington requested a review from a team as a code owner February 17, 2025 21:29
@pmaslana pmaslana merged commit ccfa35c into main Feb 20, 2025
359 of 361 checks passed
@pmaslana pmaslana deleted the quex.delete_dao branch February 20, 2025 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants