-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump chia rs 0.10.0 #18135
Merged
Merged
Bump chia rs 0.10.0 #18135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 9446953459Details
💛 - Coveralls |
f1f63aa
to
b9f6059
Compare
…. Increase end-to-end test coverage of validating message suffixes as it's moving to condition parsing
b9f6059
to
04c8034
Compare
AmineKhaldi
reviewed
Jun 10, 2024
Co-authored-by: Amine Khaldi <[email protected]>
AmineKhaldi
approved these changes
Jun 10, 2024
Pull Request Test Coverage Report for Build 9450002434Details
💛 - Coveralls |
emlowe
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Changed
Required label for PR that categorizes merge commit message as "Changed" for changelog
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is best reviewed one commit at a time.
Purpose:
Update chia_rs to the latest version, 0.10.0.
In this version, there were two major changes to the API:
The
ConsensusConstants
class, in addition toAGG_SIG_ME_ADDITIONAL_DATA
, contains the constants for all otherAGG_SIG_*
conditions as well. i.e. this is the suffix we append to the condition message before signing or verifying the signature.These fields are now used by the condition parser (in rust) to validate that
AGG_SIG_UNSAFE
messages do not end with any of these reserved suffixes. Doing so is a consensus violation. This check is currently performed inpkm_pairs()
, and this patch removes it, and updates the tests to be end-to-end, to cover the rust condition parser.The second major change is that
NO_RELATIVE_CONDITIONS_ON_EPHEMERAL
was removed, and always on. This was a soft-fork that has activated and is now part of the consensus rules.Current Behavior:
The agg sig additional data is checked in
pkm_pairs()
, in python.relative conditions are explicitly disallowed.
New Behavior:
The agg sig additional data is checked in the condition parser, in
chia_rs
.relative conditions are implicitly disallowed by being always-on in the new
chia_rs
version.