Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHIA-714] Add usage of action scope throughout wallet codebase #18128

Merged
merged 33 commits into from
Jul 17, 2024

Conversation

Quexington
Copy link
Contributor

@Quexington Quexington commented Jun 6, 2024

This PR utilizes the action scopes that were put into place in #18127 . The key idea is to give all transaction functions access to the full state of the transaction and preventing races & conflicts by utilizing the action scope primitive that allows for only a single read/writer at a time. This means that transactions don't have to be handed up the stack and hopefully submitted properly and callers of other functions can be ignorant to the stuff that those sub functions need done. This feature will be crucial for wallets where information about the entire transaction is needed before they can construct their spend.

@Quexington Quexington added the Added Required label for PR that categorizes merge commit message as "Added" for changelog label Jun 6, 2024
@Quexington Quexington changed the title Add usage of action scope throughout wallet codebase [CHIA-714] Add usage of action scope throughout wallet codebase Jun 6, 2024
@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Jun 10, 2024
@Chia-Network Chia-Network deleted a comment from github-actions bot Jun 10, 2024
@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Jun 10, 2024
@Chia-Network Chia-Network deleted a comment from github-actions bot Jun 10, 2024
@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Jun 10, 2024
@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Jun 10, 2024
@Chia-Network Chia-Network deleted a comment from github-actions bot Jun 10, 2024
@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Jul 12, 2024
@Chia-Network Chia-Network deleted a comment from github-actions bot Jul 15, 2024
@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Jul 15, 2024
@Chia-Network Chia-Network deleted a comment from github-actions bot Jul 15, 2024
Base automatically changed from quex.add_action_scope_to_all_tx_endpoints to main July 16, 2024 18:06
@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Jul 16, 2024
@Chia-Network Chia-Network deleted a comment from github-actions bot Jul 16, 2024
@Chia-Network Chia-Network deleted a comment from github-actions bot Jul 16, 2024
@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Jul 16, 2024
@Quexington Quexington marked this pull request as ready for review July 16, 2024 21:55
@Quexington Quexington requested a review from a team as a code owner July 16, 2024 21:55
Copy link
Contributor

File Coverage Missing Lines
chia/wallet/cat_wallet/cat_wallet.py 96.8% lines 614
chia/wallet/nft_wallet/nft_wallet.py 95.5% lines 1086, 1466, 1677
Total Missing Coverage
1532 lines 4 lines 99%

@Chia-Network Chia-Network deleted a comment from github-actions bot Jul 17, 2024
Copy link
Contributor

@markelrod markelrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

coverage exceptions are fine

@Starttoaster Starttoaster merged commit 0555889 into main Jul 17, 2024
373 of 374 checks passed
@Starttoaster Starttoaster deleted the quex.use_action_scopes branch July 17, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Added Required label for PR that categorizes merge commit message as "Added" for changelog coverage-diff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants