-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional partial headers #17788
Add additional partial headers #17788
Conversation
Interestingly, RFC 6648 (https://www.rfc-editor.org/rfc/rfc6648) deprecates using |
Some Internal discussion indicates that some of these would be contentious to send by default - I suggest creating a new CHIP to discuss those and they may need to be optional to send The harvester version itself is likely not controversial - but some of the others eliciting some internal feedback |
which ones exactly? |
Farmer peer ID. This might work well as an informational CHIP if there are other clients that could use it. I'm not familiar enough with the pooling protocols to say for sure, though. |
I don't see how that is contentious in any way, but sure i can create a chip for it |
The CHIP PR is available here: Chia-Network/chips#114 |
This PR has been flagged as stale due to no activity for over 60 days. It will not be automatically closed, but it has been given a stale-pr label and should be manually reviewed by the relevant parties. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Per the conversation in the chip, the inherent security issues with defaulting the additional headers to not be obfuscated, and the reduced version of the pr already adoption; this pr is being closed and not adopted into the chia codebase. |
Purpose:
Expose farmer peer id, full harvester version, harvester capacity (raw/effective) and plot count when submitting a partial.
Current Behavior:
Currently only the full farmer version and harvester peer id are exposed
New Behavior:
Farmer and harvester peer id and full version, as well as harvester capacity and plot count are exposed.
Testing Notes:
Limitation: capacity and plot count are not scoped by plotnft yet, as those are not tracked separately right now in
plot_sync_receivers
. The current lookups are fast as its just a direct variable access, scoping per launcher id/contract address would require additional compute resources without a refactor of how plot_sync_receivers works right now.Handshake
#15679