Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for observance of melted CAT balance #17764

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Conversation

Quexington
Copy link
Contributor

This is in response to #17727

Currently, our wallet does not properly handle the following flow: syncing -> actions being taken outside the wallet on non-XCH -> syncing

Actions taken by our wallet don't suffer from this problem because they create transaction records that have effects on the subscriptions we make to full nodes. Without this transaction record, we don't subscribe apparently to coins that we have already received by a hint. When something other than our wallet spends our coins, we fail to get notified of this removal and this results in an incorrect balance.

@Quexington Quexington marked this pull request as ready for review March 21, 2024 20:07
@Quexington Quexington requested a review from a team as a code owner March 21, 2024 20:07
@Quexington Quexington added the Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog label Mar 21, 2024
Copy link
Contributor

@wjblanke wjblanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aok

Copy link

Pull Request Test Coverage Report for Build 8381104615

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 37 of 37 (100.0%) changed or added relevant lines in 2 files are covered.
  • 34 unchanged lines in 11 files lost coverage.
  • Overall coverage decreased (-0.009%) to 90.815%

Files with Coverage Reduction New Missed Lines %
chia/_tests/simulation/test_simulation.py 1 96.52%
chia/full_node/full_node_api.py 1 79.32%
chia/rpc/rpc_server.py 1 87.67%
chia/pools/pool_wallet.py 1 89.02%
chia/full_node/weight_proof.py 2 90.73%
chia/timelord/timelord.py 3 73.56%
chia/_tests/core/daemon/test_daemon.py 3 99.45%
chia/full_node/full_node.py 3 84.85%
chia/server/node_discovery.py 4 79.08%
chia/server/server.py 4 80.0%
Totals Coverage Status
Change from base Build 8378992295: -0.009%
Covered Lines: 97437
Relevant Lines: 107269

💛 - Coveralls

@Quexington Quexington added the ready_to_merge Submitter and reviewers think this is ready label Mar 22, 2024
@emlowe emlowe linked an issue Mar 22, 2024 that may be closed by this pull request
@Quexington Quexington closed this Mar 25, 2024
@Quexington Quexington reopened this Mar 25, 2024
@pmaslana pmaslana merged commit 6428a3b into main Mar 25, 2024
569 checks passed
@pmaslana pmaslana deleted the quex.melting_cats branch March 25, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog ready_to_merge Submitter and reviewers think this is ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Incorrect spendable amount after melting (a meltable) CAT
4 participants