Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speedup leaf_hash in data_layer_util.py #17759

Merged

Conversation

AmineKhaldi
Copy link
Contributor

Making it also type safe as a result.

@AmineKhaldi AmineKhaldi added Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Cleanup Code cleanup labels Mar 21, 2024
@AmineKhaldi AmineKhaldi self-assigned this Mar 21, 2024
@emlowe
Copy link
Contributor

emlowe commented Mar 21, 2024

Close and reopen for benchmarks fix

@emlowe emlowe closed this Mar 21, 2024
@emlowe emlowe reopened this Mar 21, 2024
Copy link

Pull Request Test Coverage Report for Build 8380938680

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 16 unchanged lines in 8 files lost coverage.
  • Overall coverage increased (+0.01%) to 90.834%

Files with Coverage Reduction New Missed Lines %
chia/rpc/rpc_server.py 1 88.67%
chia/_tests/core/util/test_lockfile.py 1 91.09%
chia/server/node_discovery.py 1 79.96%
chia/rpc/wallet_rpc_api.py 1 89.2%
chia/introducer/introducer.py 1 78.26%
chia/wallet/wallet_node.py 2 88.56%
chia/server/server.py 4 80.0%
chia/introducer/introducer_api.py 5 78.26%
Totals Coverage Status
Change from base Build 8378992295: 0.01%
Covered Lines: 97426
Relevant Lines: 107233

💛 - Coveralls

@AmineKhaldi AmineKhaldi marked this pull request as ready for review March 22, 2024 11:29
@AmineKhaldi AmineKhaldi requested a review from a team as a code owner March 22, 2024 11:29
@AmineKhaldi AmineKhaldi requested a review from emlowe March 22, 2024 11:30
@pmaslana pmaslana merged commit 5350428 into Chia-Network:main Mar 25, 2024
564 of 565 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Cleanup Code cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants