Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve get_seconds_and_delayed_puzhash_from_p2_singleton_puzzle #17746

Conversation

AmineKhaldi
Copy link
Contributor

  • Construct delayed_puzzle_hash as a proper bytes32 object.
  • Mark unused values.
  • Handle atom optionality before constructing return values.

@AmineKhaldi AmineKhaldi added Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Cleanup Code cleanup labels Mar 20, 2024
@AmineKhaldi AmineKhaldi self-assigned this Mar 20, 2024
@AmineKhaldi AmineKhaldi reopened this Mar 22, 2024
Copy link

coveralls-official bot commented Mar 22, 2024

Pull Request Test Coverage Report for Build 8424424183

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • 22 unchanged lines in 9 files lost coverage.
  • Overall coverage decreased (-0.006%) to 90.831%

Files with Coverage Reduction New Missed Lines %
chia/_tests/util/setup_nodes.py 1 98.35%
chia/timelord/timelord_launcher.py 1 69.92%
chia/full_node/full_node.py 1 84.95%
chia/wallet/wallet_node.py 2 88.49%
chia/data_layer/data_layer_wallet.py 2 91.1%
chia/timelord/timelord.py 3 73.56%
chia/rpc/rpc_server.py 3 88.0%
chia/full_node/weight_proof.py 4 90.73%
chia/_tests/core/util/test_lockfile.py 5 89.47%
Totals Coverage Status
Change from base Build 8423807279: -0.006%
Covered Lines: 97431
Relevant Lines: 107240

💛 - Coveralls

@AmineKhaldi AmineKhaldi marked this pull request as ready for review March 22, 2024 13:43
@AmineKhaldi AmineKhaldi requested a review from a team as a code owner March 22, 2024 13:43
@AmineKhaldi AmineKhaldi requested a review from Quexington March 22, 2024 13:43
Quexington
Quexington previously approved these changes Mar 22, 2024
Copy link
Contributor

@Quexington Quexington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't matter but can we also get rid of the list cast here on args.as_iter()?

* Construct delayed_puzzle_hash as a proper bytes32 object.
* Mark unused values.
* Handle atom optionality before constructing return values.
@AmineKhaldi AmineKhaldi force-pushed the improve_get_seconds_and_delayed_puzhash_from_p2_singleton_puzzle branch from 55b142e to d013fc4 Compare March 25, 2024 17:32
@AmineKhaldi
Copy link
Contributor Author

It doesn't matter but can we also get rid of the list cast here on args.as_iter()?

Thanks, done.

@AmineKhaldi AmineKhaldi requested a review from Quexington March 25, 2024 17:32
@pmaslana pmaslana merged commit 97cd5a9 into Chia-Network:main Mar 26, 2024
284 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Cleanup Code cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants