Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix non-development source install #17669

Merged
merged 5 commits into from
Mar 7, 2024
Merged

fix non-development source install #17669

merged 5 commits into from
Mar 7, 2024

Conversation

altendky
Copy link
Contributor

@altendky altendky commented Mar 7, 2024 •
edited
Loading

Purpose:

Current Behavior:

New Behavior:

Testing Notes:

Draft For:

  • adding a test of at least the no-parameters case

@altendky altendky added the Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog label Mar 7, 2024
@altendky altendky marked this pull request as ready for review March 7, 2024 20:35
@altendky altendky requested a review from a team as a code owner March 7, 2024 20:35
@altendky altendky requested a review from cmmarslender March 7, 2024 20:35
@Starttoaster Starttoaster merged commit d412b87 into main Mar 7, 2024
278 checks passed
@Starttoaster Starttoaster deleted the fix_non_development_source_install branch March 7, 2024 22:37
@madMAx43v3r
Copy link

Thx, this kept me from building GH 2.2.1 on Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmmarslender cmmarslender cmmarslender approved these changes

Assignees
No one assigned
Labels
Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@altendky @madMAx43v3r @cmmarslender @Starttoaster