use click.Path for make_offer command filename #17538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emlowe
added
the
Fixed
|
arvidn
approved these changes
Feb 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10920
Addresses several issues with the seldom used
make_offerCLI option. Usesclick.Pathtype to avoid problems with using a directory or a non-writable file and added a couple of tests for those. This allowsclickto handle most error cases upfront.Also, make sure to only make the offer after opening the file for writing, which would help to prevent other problems with creating the offer while being unable to write out to the file. Doesn't address all situations like running out of disk space, but this likely works for the large majority of failure cases.