remove support for migrating peers from legacy file format #17517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arvidn
added
the
Changed
arvidn
force-pushed
the
remove-legacy-peer-database
branch
from
b9ec672 to
21f9891
Compare
arvidn
force-pushed
the
remove-legacy-peer-database
branch
from
21f9891 to
41a44ef
Compare
fchirica
approved these changes
Feb 8, 2024
|
I've tested this with a fresh install as well as resuming |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose:
In November 2021, we migrated our file format for storing peers from a sqlite database to a flat file.
#9079
This PR removes the remnants of the backwards compatibility left in place in that PR.
Current Behavior:
We have code that's not likely to be used, supporting loading peers from the old sqlite format.
New Behavior:
We have less code, and don't support loading peers from the old, sqlite, format.