Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hint support for SpendSim #17490

Merged
merged 5 commits into from
Feb 15, 2024
Merged

Conversation

trepca
Copy link
Contributor

@trepca trepca commented Feb 5, 2024

Purpose:

Added hint support for SpendSim

Current Behavior:

Can't fetch coin records by hints

@Quexington Quexington added the Added Required label for PR that categorizes merge commit message as "Added" for changelog label Feb 5, 2024
Copy link

coveralls-official bot commented Feb 5, 2024

Pull Request Test Coverage Report for Build 7910970662

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 60 (100.0%) changed or added relevant lines in 2 files are covered.
  • 389 unchanged lines in 39 files lost coverage.
  • Overall coverage increased (+0.02%) to 90.89%

Files with Coverage Reduction New Missed Lines %
chia/daemon/client.py 1 84.38%
chia/daemon/keychain_proxy.py 1 64.98%
chia/data_layer/download_data.py 1 71.04%
chia/farmer/farmer.py 1 72.67%
chia/rpc/wallet_rpc_api.py 1 89.57%
chia/timelord/timelord_launcher.py 1 70.54%
chia/wallet/db_wallet/db_wallet_puzzles.py 1 98.44%
chia/wallet/wallet_state_manager.py 1 96.38%
tests/fee_estimation/test_fee_estimation_unit_tests.py 1 99.06%
tests/simulation/test_simulation.py 1 96.52%
Totals Coverage Status
Change from base Build 7862182797: 0.02%
Covered Lines: 97240
Relevant Lines: 106943

💛 - Coveralls

@trepca trepca marked this pull request as ready for review February 11, 2024 06:14
@trepca trepca requested a review from a team as a code owner February 11, 2024 06:14
@arvidn
Copy link
Contributor

arvidn commented Feb 11, 2024

Diff Coverage
Diff: origin/main...HEAD, staged and unstaged changes
-------------
chia/clvm/spend_sim.py (90.9%): Missing lines 481,483
tests/clvm/test_spend_sim.py (100%)
-------------
Total:   36 lines
Missing: 2 lines
Coverage: 94%
-------------

@Starttoaster Starttoaster merged commit b514646 into Chia-Network:main Feb 15, 2024
262 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Added Required label for PR that categorizes merge commit message as "Added" for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants