Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate short option from make_offer command #17376

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Remove duplicate short option from make_offer command #17376

merged 1 commit into from
Jan 22, 2024

Conversation

Quexington
Copy link
Contributor

@Quexington Quexington marked this pull request as ready for review January 22, 2024 15:16
@Quexington Quexington requested a review from a team as a code owner January 22, 2024 15:16
@Quexington Quexington added the Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog label Jan 22, 2024
@coveralls-official Coveralls Official
Copy link

Pull Request Test Coverage Report for Build 7613326690

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 90.551%
Totals Coverage Status
Change from base Build 7601805424: -0.1%
Covered Lines: 94748
Relevant Lines: 104585
💛 - Coveralls

wjblanke
wjblanke approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@wjblanke wjblanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aok

@Quexington Quexington added the ready_to_merge Submitter and reviewers think this is ready label Jan 22, 2024
@Quexington Quexington changed the title Remove duplicate short option Remove duplicate short option from make_offer command Jan 22, 2024
@Starttoaster Starttoaster merged commit c0f7fd3 into main Jan 22, 2024
266 of 267 checks passed
@Starttoaster Starttoaster deleted the quex.override_not_0 branch January 22, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjblanke wjblanke wjblanke approved these changes

Assignees
No one assigned
Labels
Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog ready_to_merge Submitter and reviewers think this is ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Quexington @wjblanke @Starttoaster