Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix duplicates file and upload name uniqueness #17354

Merged
merged 6 commits into from
Jan 21, 2024

Conversation

altendky
Copy link
Contributor

@altendky altendky commented Jan 18, 2024

Purpose:

uploaded artifacts must now have unique names. also, this makes the file names unique for coverage and pytest outputs so they can all make it to the post job without clobbering each other.

Current Behavior:

New Behavior:

Testing Notes:

@altendky altendky requested a review from a team as a code owner January 18, 2024 13:16
@altendky altendky added Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog Exclude_Notes Use this label if the changes in the PR should be excluded from the release notes labels Jan 18, 2024
@altendky altendky marked this pull request as draft January 18, 2024 13:16
@altendky altendky marked this pull request as ready for review January 18, 2024 13:52
@altendky altendky requested a review from AmineKhaldi January 18, 2024 13:52
@altendky altendky closed this Jan 19, 2024
@altendky altendky reopened this Jan 19, 2024
@altendky altendky closed this Jan 19, 2024
@altendky altendky reopened this Jan 19, 2024
Copy link
Contributor

File Coverage Missing Lines
tests/build-job-matrix.py 80.0% lines 153-154
Total Missing Coverage
10 lines 2 lines 80%

Copy link

Pull Request Test Coverage Report for Build 7590064577

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.07%) to 90.58%

Totals Coverage Status
Change from base Build 7589765628: -0.07%
Covered Lines: 94772
Relevant Lines: 104584

💛 - Coveralls

@cmmarslender cmmarslender merged commit 4711c52 into main Jan 21, 2024
771 of 776 checks passed
@cmmarslender cmmarslender deleted the fix_duplicates_file_and_upload_name_uniqueness branch January 21, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Exclude_Notes Use this label if the changes in the PR should be excluded from the release notes Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants