Check dependencies to avoid a useless sudo on Archlinux #17158
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose:
Prevent a useless call to
sudo
during this installation of Chia on Archlinux, by checking if the dependencies are not already installed.The point is to make the installation easier:
sudo
forces the user to type its password (event if there is nothing to do).su
and don't setupsudo
. In this case, the installation of chia is impossible without modifying theinstal.sh
. (it's what I do for years)Old Behavior:
Calling
sudo
every time to install the dependencies.New Behavior:
Verify if
git
andopenssl
are installed, then callsudo pacman -S git openssl
only if needed.Testing Notes:
I wanted to keep the existing code, so I simply added a if statement. But in fact, we can simplify the code for Archlinux:
no dependencies needs to be installed (at least line 213), because: