Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump chia_rs to 0.3.3 #17074

Merged
merged 1 commit into from
Dec 18, 2023
Merged

bump chia_rs to 0.3.3 #17074

merged 1 commit into from
Dec 18, 2023

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented Dec 16, 2023

Purpose:

The latest version of chia_rs includes:

  • pre-softfork 3 logic was removed, allowing some simplifications
  • updated fast_forward_singleton() to allow changing coin amount
  • fix to SerializedProgram.to() to match the python implementation
  • full node class types
  • "unchecked" versions of from_bytes() and parse() in the streamable protocol (for improved performance of trusted input)
  • fix __repr__ for types exported to python

Current Behavior:

New Behavior:

Testing Notes:

@arvidn arvidn added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label Dec 16, 2023
Copy link

coveralls-official bot commented Dec 17, 2023

Pull Request Test Coverage Report for Build 7246903817

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 25 unchanged lines in 9 files lost coverage.
  • Overall coverage remained the same at 90.412%

Files with Coverage Reduction New Missed Lines %
chia/daemon/client.py 1 85.0%
chia/full_node/full_node_api.py 1 77.33%
chia/full_node/full_node.py 1 84.97%
chia/introducer/introducer.py 1 78.26%
chia/server/node_discovery.py 1 78.87%
chia/timelord/timelord.py 2 73.67%
chia/server/server.py 4 79.66%
chia/introducer/introducer_api.py 5 78.26%
chia/wallet/wallet_node.py 9 87.72%
Totals Coverage Status
Change from base Build 7224265861: 0.0%
Covered Lines: 93795
Relevant Lines: 103697

💛 - Coveralls

@arvidn arvidn marked this pull request as ready for review December 17, 2023 11:43
@arvidn arvidn requested a review from a team as a code owner December 17, 2023 11:43
@arvidn arvidn requested a review from AmineKhaldi December 17, 2023 12:12
@arvidn arvidn force-pushed the bump-clvm-rs-0.3.3 branch from 6f79e49 to 5bd00c3 Compare December 18, 2023 10:38
@arvidn arvidn requested a review from wjblanke December 18, 2023 17:41
Copy link
Contributor

@wjblanke wjblanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aok

@cmmarslender cmmarslender merged commit d526125 into main Dec 18, 2023
@cmmarslender cmmarslender deleted the bump-clvm-rs-0.3.3 branch December 18, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants