Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TX amount calculation in trade manager #16934

Merged
merged 3 commits into from
Dec 7, 2023
Merged

Conversation

Quexington
Copy link
Contributor

@Quexington Quexington commented Nov 27, 2023

@Quexington Quexington added the Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog label Nov 27, 2023
@Quexington Quexington marked this pull request as ready for review November 27, 2023 17:02
@Quexington Quexington requested a review from a team as a code owner November 27, 2023 17:02
Copy link

coveralls-official bot commented Nov 27, 2023

Pull Request Test Coverage Report for Build 7021690610

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 6 of 6 (100.0%) changed or added relevant lines in 2 files are covered.
  • 65 unchanged lines in 11 files lost coverage.
  • Overall coverage decreased (-0.04%) to 90.254%

Files with Coverage Reduction New Missed Lines %
chia/rpc/wallet_rpc_api.py 1 88.06%
chia/simulator/setup_nodes.py 1 98.31%
chia/rpc/rpc_server.py 2 88.01%
chia/timelord/timelord.py 2 73.67%
chia/consensus/block_creation.py 5 80.17%
chia/server/address_manager.py 5 90.36%
tests/core/util/test_lockfile.py 5 88.66%
chia/daemon/server.py 7 86.48%
chia/full_node/full_node.py 7 84.28%
chia/server/node_discovery.py 8 78.18%
Totals Coverage Status
Change from base Build 7007825064: -0.04%
Covered Lines: 93545
Relevant Lines: 103587

💛 - Coveralls

@aqk
Copy link
Contributor

aqk commented Nov 28, 2023

This looks great. You should add a test that fails in main and passes on this branch.

@Quexington Quexington closed this Dec 6, 2023
@Quexington Quexington reopened this Dec 6, 2023
@Quexington Quexington closed this Dec 6, 2023
@Quexington Quexington reopened this Dec 6, 2023
Copy link
Contributor

@wjblanke wjblanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aok

@cmmarslender cmmarslender merged commit 68afc8c into main Dec 7, 2023
@cmmarslender cmmarslender deleted the quex.fix_tx_amt_calc branch December 7, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants