Optimize CRCAT trades #16430
Merged
Optimize CRCAT trades #16430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quexington
added
Added
arvidn
reviewed
Sep 27, 2023
Quexington
force-pushed
the
quex.crcat_optimizations
branch
from
c9af97b to
1a94a8a
Compare
arvidn
reviewed
Oct 19, 2023
arvidn
approved these changes
Oct 19, 2023
This was referenced Oct 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was some low hanging optimizations that could be made to CRCATs and offers more generally. This PR combines those changes which should result in a ~35% speed up to trade tests involving CRCATs.