Fix chia farm summary aborting early if no local full node present
#16387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
altendky
added
the
Fixed
altendky
requested changes
Sep 21, 2023
There was a problem hiding this comment.
It would be nice to provide at least some information about the failure, in addition to the other information. At least for most errors. Maybe we could specifically handle ClientConnectorError in a quiet way and provide noisier output for all other exceptions? I'm ok with continuing on in both cases and providing the rest of the information we can provide.
|
Also... Thank you! |
|
Yes, that's a good idea. Updated to silently handle |
xearl4
force-pushed
the
fix-chia-farm-summary
branch
2 times, most recently
from
499fcb2 to
5c1a3d6
Compare
altendky
reviewed
Sep 22, 2023
xearl4
force-pushed
the
fix-chia-farm-summary
branch
from
5c1a3d6 to
697b89c
Compare
altendky
reviewed
Sep 22, 2023
xearl4
force-pushed
the
fix-chia-farm-summary
branch
from
697b89c to
0f6a317
Compare
altendky
previously approved these changes
Sep 22, 2023
|
Actually, sorry, could you rebase and retarget this to |
Before 2.0, even if no local full node was present, `chia farm summary`
would still show useful information:
$ chia farm summary
Farming status: Not available
Local Harvester
1 plots of size: 101.320 GiB on-disk, 101.400 GiBe (effective)
Plot count for all harvesters: 1
Total size of plots: 101.320 GiB, 101.400 GiBe (effective)
Estimated network space: Unknown
Expected time to win: Unknown
For details on farmed rewards and fees you should run 'chia start wallet' and 'chia wallet show'
However, since 2.0, that is no longer the case. `chia farm summary`
simply aborts with an exception:
$ chia farm summary
Error: Connection error: ClientConnectorError: Cannot connect to host localhost:8555 ssl:<ssl.SSLContext object at 0x7fe0edd533c0> [Connect call failed ('127.0.0.1', 8555)]
Check if full node rpc is running at 8555
This is normal if full node is still starting up
This fixes this particular regression which is rather annoying for
farmers farming to a remote node.
Fixes Chia-Network#16164. Related to issue Chia-Network#9615, but that issue is wider in scope.
With this change, only the exceptions when failing to connect to a local full node and/or wallet are suppressed, as these cases are already properly handled by adjusted command output. Any other exception is printed to stderr.
xearl4
force-pushed
the
fix-chia-farm-summary
branch
from
0f6a317 to
9ffb0ce
Compare
Sure, done. And thanks for your review! |
altendky
approved these changes
Sep 23, 2023
emlowe
approved these changes
Sep 25, 2023
This was referenced Oct 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before 2.0, even if no local full node was present,
chia farm summarywould still show useful information:However, since 2.0, that is no longer the case.
chia farm summarysimply aborts with an exception:This fixes this particular regression which is rather annoying for farmers farming to a remote node.
Fixes #16164. Related to issue #9615, but that issue is wider in scope.