Don't autopush txs across RPC #16314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quexington
added
the
Changed
github-actions
bot
added
the
merge_conflict
github-actions
bot
removed
the
merge_conflict
github-actions
bot
added
the
merge_conflict
github-actions
bot
removed
the
merge_conflict
github-actions
bot
added
merge_conflict
geoffwalmsley
previously approved these changes
Sep 28, 2023
github-actions
bot
added
merge_conflict
github-actions
bot
removed
the
merge_conflict
Quexington
force-pushed
the
quex.all_tx_pushing_optional
branch
from
d6dc533 to
75555f5
Compare
…tx_pushing_optional
Quexington
force-pushed
the
quex.all_tx_pushing_optional
branch
from
95fb566 to
853b793
Compare
…tx_pushing_optional
github-actions
bot
added
merge_conflict
Quexington
force-pushed
the
quex.all_tx_pushing_optional
branch
from
e2553cd to
25cd068
Compare
…tx_pushing_optional
Quexington
force-pushed
the
quex.all_tx_pushing_optional
branch
from
25cd068 to
8ae964d
Compare
github-actions
bot
added
the
merge_conflict
…tx_pushing_optional
github-actions
bot
removed
the
merge_conflict
|
geoffwalmsley
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a step in the direction of a more observer-style wallet.
Currently, most of our wallet functions just push directly to the network as a matter of course when creating a transaction. While this is convenient (especially in tests) it will be impossible should we get to a wallet design that does not contain the private key as a key component to wallet operations.
For now, the wallet still signs the transaction and has it ready to be pushed to the network should the user specify that. But all of the pushing logic has been migrated to the top-most layer available (usually the RPC) so that the user always has control over whether or not they would like to immediately push the transaction.
In addition, any transaction method in the RPC now returns a
"transactions"key so that it is easy for a front-end client to have everything they need to push the transaction as if the wallet was doing it (using thepush_transactionsendpoint).