dao wallet cleanup #15753
Merged
dao wallet cleanup #15753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
merge_conflict
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
removed
the
merge_conflict
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
matt-o-how
reviewed
Jul 13, 2023
chia/wallet/dao_wallet/dao_wallet.py
Outdated
|
|
||
| class DAOWallet(WalletProtocol): | ||
| """ | ||
| This is a wallet in the sense that it conforms to the interface needed by WalletStateManager. | ||
| It is not a user-facing wallet. A user cannot spend or receive XCH though a wallet of this type. | ||
|
|
||
| It is expected that a wallet of type DAOCATWallet will be the user-facing wallet, and use a | ||
| DAOWallet for state-tracking of the Treasury Singleton and its associated Proposals. | ||
| Wallets of type CAT and DAO_CAT are be the user-facing wallets which hold the voting tokens a user |
matt-o-how
reviewed
Jul 13, 2023
| @@ -321,12 +296,12 @@ async def create_new_dao_wallet_from_coin_spend( | |||
| self.log = logging.getLogger(name if name else __name__) | |||
|
|
|||
| self.log.info(f"Creating DAO wallet from a coin spend {launch_coin.name()} ...") | |||
| # Create did info from the coin spend | |||
| # Create dao info from the coin spend | |||
There was a problem hiding this comment.
Do we want to comment out this whole function given we aren't using it or testing it and it probably doesn't work?
matt-o-how
reviewed
Jul 13, 2023
| # breakpoint() | ||
| # add interested puzzle hash so we can folllow treasury funds and proposals | ||
|
|
||
| # add treasury id to interested puzzle hashes so we can folllow treasury funds |
There was a problem hiding this comment.
We should mention this is for the hints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tidy up and some refactoring of dao_wallet.py