Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hybrid img three #54

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Hybrid img three #54

merged 1 commit into from
Aug 7, 2023

Conversation

samtkaplan
Copy link
Member

replacement for #52. depends on ChevronETC/WaveFD.jl#41

@samtkaplan samtkaplan requested a review from MatthewEai August 4, 2023 16:25
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 46.29% and project coverage change: -0.50% ⚠️

Comparison is base (ea1ae2a) 85.00% compared to head (0d182d6) 84.50%.

❗ Current head 0d182d6 differs from pull request most recent head c150fb6. Consider uploading reports for the commit c150fb6 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #54      +/-   ##
==========================================
- Coverage   85.00%   84.50%   -0.50%     
==========================================
  Files          10       10              
  Lines        2320     2168     -152     
==========================================
- Hits         1972     1832     -140     
+ Misses        348      336      -12     
Files Changed Coverage Δ
src/jop_prop2DAcoIsoDenQ_DEO2_FDTD.jl 85.41% <44.44%> (-0.67%) ⬇️
src/jop_prop2DAcoTTIDenQ_DEO2_FDTD.jl 85.06% <44.44%> (-0.66%) ⬇️
src/jop_prop2DAcoVTIDenQ_DEO2_FDTD.jl 84.49% <44.44%> (-0.69%) ⬇️
src/jop_prop3DAcoIsoDenQ_DEO2_FDTD.jl 85.80% <44.44%> (-0.65%) ⬇️
src/jop_prop3DAcoTTIDenQ_DEO2_FDTD.jl 85.19% <44.44%> (-0.64%) ⬇️
src/jop_prop3DAcoVTIDenQ_DEO2_FDTD.jl 85.32% <55.55%> (-0.36%) ⬇️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samtkaplan samtkaplan merged commit 073eb3a into master Aug 7, 2023
@samtkaplan samtkaplan deleted the hybrid_img_three branch August 7, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants