Copy from local to blob and vice-versa with a buffer size. #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samtkaplan
force-pushed
the
chunkcopy
branch
2 times, most recently
from
dfa1280 to
2d5ff6c
Compare
|
Do we need a test with a larger data upload/download, setting n= 500_000_000? If this will be too much for the agents, should we test using a demo? |
|
@anushasekar1 I don't think that is needed. We should be able to test the functionality with a "unit" test. But, definitely, feel free to make bigger tests, but I would suggest making those independent from this package. In other words, if that bigger test fails, I would presume that we can replicate that failure case with a small example. |
anushasekar1
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to support copying large blobs (larger than the machine's memory).