fix: ui issues in compose #970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug Fixes
Features
StylesChore
ContributorsCommit-Lint commandsYou can trigger Commit-Lint actions by commenting on this PR:
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #970 +/- ##
=======================================
Coverage 77.49% 77.50%
=======================================
Files 150 150
Lines 2173 2178 +5
Branches 233 236 +3
=======================================
+ Hits 1684 1688 +4
- Misses 412 413 +1
Partials 77 77
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
Remove the gap on the sides in the config screen when selecting an item |
|
Animation going into a series detail screen? |
|
Rating dialogue needs its buttons moved to the side to match other dialogs |
In the settings screen the clickable area is too small, fix the order of modifiers to fix this.
If we get a 401 during normal operation, then attempt to refresh and throw an error if we cant.
Add a new extension method to allow autofill and use this on the credentials screen.
Update padding to include the whole line in the config screen.
Move the dialog buttons to be end aligned like the other dialogs.
Chesire
force-pushed
the
fix/ui-issues-in-compose
branch
from
648f1c8 to
163e2f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix various ui issues that arose from switching to compose.
Except 1410f07, this is something that has always been around that needed fixing.