Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: content missing on some screens #961

Merged
merged 2 commits into from
Apr 20, 2023
Merged

Conversation

Chesire
Copy link
Owner

@Chesire Chesire commented Apr 18, 2023

Some screens on small phones were unusable, have added scrolling on these screens now.

Some screens on small phones were unusable, have added scrolling on these screens now.
@Chesire Chesire self-assigned this Apr 18, 2023
@commit-lint
Copy link

commit-lint bot commented Apr 18, 2023

Bug Fixes

  • content missing on some screens (6a84bf1)

Styles

Contributors

Chesire

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (14ce622) 77.49% compared to head (6a84bf1) 77.49%.

❗ Current head 6a84bf1 differs from pull request most recent head 4852be7. Consider uploading reports for the commit 4852be7 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #961   +/-   ##
=======================================
  Coverage   77.49%   77.49%           
=======================================
  Files         150      150           
  Lines        2173     2173           
  Branches      233      233           
=======================================
  Hits         1684     1684           
  Misses        412      412           
  Partials       77       77           
Impacted Files Coverage Δ
...sire/nekome/app/settings/config/ui/ConfigScreen.kt 0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Chesire Chesire merged commit 180a7f6 into master Apr 20, 2023
@Chesire Chesire deleted the fix/screens-on-small-phones branch April 20, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant