Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix the ui tests failing to compile #948

Merged
merged 1 commit into from
Apr 10, 2023

Conversation

Chesire
Copy link
Owner

@Chesire Chesire commented Apr 10, 2023

Mistakenly was overwriting the applicationPreferences in the ActivityTests file, remove this so the tests can compile again.

@Chesire Chesire self-assigned this Apr 10, 2023
@commit-lint
Copy link

commit-lint bot commented Apr 10, 2023

Tests

  • fix the ui tests failing to compile (4b0862e)

Contributors

Chesire

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@codecov
Copy link

codecov bot commented Apr 10, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (ca23d9f) 83.14% compared to head (4b0862e) 83.14%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #948   +/-   ##
=======================================
  Coverage   83.14%   83.14%           
=======================================
  Files         152      152           
  Lines        2088     2088           
  Branches      246      246           
=======================================
  Hits         1736     1736           
  Misses        277      277           
  Partials       75       75           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Chesire Chesire merged commit d104152 into master Apr 10, 2023
@Chesire Chesire deleted the test/fix-ui-test-compilation branch April 10, 2023 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant