Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: switch to use kover #903

Merged
merged 3 commits into from
Jan 10, 2023
Merged

chore: switch to use kover #903

merged 3 commits into from
Jan 10, 2023

Conversation

Chesire
Copy link
Owner

@Chesire Chesire commented Jan 10, 2023

Switch from using Jacoco to using Kover instead.

@Chesire Chesire self-assigned this Jan 10, 2023
@commit-lint
Copy link

commit-lint bot commented Jan 10, 2023

Chore

  • remove jacoco and begin using kover (d17b754)
  • add kover to the version catalogue (9acb614)

Continuous Integration

  • update github action files to run kover (b16dfcd)

Contributors

Chesire

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

with:
distribution: 'adopt'
java-version: 11
- name: run kover
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two lines are the only changes, everything else was VSCode auto formatting

@Chesire Chesire marked this pull request as ready for review January 10, 2023 00:29
@codecov
Copy link

codecov bot commented Jan 10, 2023

Codecov Report

Base: 68.79% // Head: 73.77% // Increases project coverage by +4.98% 🎉

Coverage data is based on head (b16dfcd) compared to base (0f466a7).
Patch coverage: 90.88% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #903      +/-   ##
============================================
+ Coverage     68.79%   73.77%   +4.98%     
============================================
  Files           109      139      +30     
  Lines          1679     1903     +224     
  Branches        145      240      +95     
============================================
+ Hits           1155     1404     +249     
+ Misses          478      433      -45     
- Partials         46       66      +20     
Impacted Files Coverage Δ
...kome/app/login/credentials/ui/CredentialsScreen.kt 0.00% <0.00%> (ø)
...esire/nekome/app/login/syncing/ui/SyncingScreen.kt 0.00% <0.00%> (ø)
...om/chesire/nekome/app/search/domain/SearchModel.kt 100.00% <ø> (+27.27%) ⬆️
...om/chesire/nekome/app/search/host/ui/HostScreen.kt 0.00% <0.00%> (ø)
...sire/nekome/app/search/results/ui/ResultsScreen.kt 0.00% <0.00%> (ø)
...nekome/datasource/auth/local/PreferenceProvider.kt 0.00% <0.00%> (ø)
...ire/nekome/app/search/host/data/HostPreferences.kt 75.00% <75.00%> (ø)
...e/app/login/credentials/ui/CredentialsViewModel.kt 80.00% <80.00%> (ø)
...chesire/nekome/app/search/host/ui/HostViewModel.kt 80.43% <80.43%> (ø)
...me/app/login/syncing/core/RetrieveAvatarUseCase.kt 87.50% <87.50%> (ø)
... and 112 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Chesire Chesire merged commit bfd5a0d into master Jan 10, 2023
@Chesire Chesire deleted the chore/switch-to-use-kover branch January 10, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant