refactor: use compose for results screen #901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the old results screen with the new files.
Make updates to the screen to try to reproduce old results screen.
Finish the compose screen for the resutls view, replacing the TRACK button with a plus icon instead.
Features
Code Refactoring
TestsStyles
Chore
ContributorsCommit-Lint commandsYou can trigger Commit-Lint actions by commenting on this PR:
|
|
Need to remove some of the old dependencies from the gradle file, and remove some of the now unused images
|
ChesireBot
reviewed
Jan 8, 2023
| } | ||
| } | ||
|
|
||
| fun trackNewSeries(resultModel: ResultModel) { |
There was a problem hiding this comment.
| The function trackNewSeries is too long (32). The maximum length is 30. |
Generated by 🚫 Danger |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the results screen so it makes use of Compose.
Along with this, refactored the old viewmodel so it hands off work to some use cases instead.
This PR has some minor UI changes to the results screen.