Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to sort by rating #690

Merged
merged 2 commits into from
Dec 6, 2021
Merged

Add ability to sort by rating #690

merged 2 commits into from
Dec 6, 2021

Conversation

tlaporte
Copy link
Contributor

@tlaporte tlaporte commented Dec 5, 2021

Small change to allow sorting by rating.

Would be nice to choose ascending/descending sort as well, but this was simple enough to do with no experience working on Android.

This was tested in the emulator in Android Studio.

@commit-lint
Copy link

commit-lint bot commented Dec 5, 2021

Features

  • add ability to sort by rating (ab9053f)

Tests

  • fix copy/paste error on sort by rating function name (81f9a85)

Contributors

tlaporte

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@codecov
Copy link

codecov bot commented Dec 5, 2021

Codecov Report

Merging #690 (81f9a85) into master (3b1e2cb) will decrease coverage by 0.02%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #690      +/-   ##
============================================
- Coverage     69.09%   69.07%   -0.03%     
  Complexity      440      440              
============================================
  Files           109      109              
  Lines          1676     1678       +2     
  Branches        142      142              
============================================
+ Hits           1158     1159       +1     
- Misses          475      476       +1     
  Partials         43       43              
Impacted Files Coverage Δ
...esire/nekome/app/series/list/view/SeriesAdapter.kt 0.00% <0.00%> (ø)
...n/java/com/chesire/nekome/core/flags/SortOption.kt 85.71% <100.00%> (+2.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b1e2cb...81f9a85. Read the comment docs.

@Chesire
Copy link
Owner

Chesire commented Dec 6, 2021

Hey there , thanks for this, changes look solid.
Just to clarify, the intention is to sort by user rating correct?

@tlaporte
Copy link
Contributor Author

tlaporte commented Dec 6, 2021

Yeah, I find it useful to look at my list sorted by my rating to see what I liked/disliked most pretty easily. This and the ability to choose ascending/descending sort are the only features for my use case that are missing vs the Kitsu app, but I prefer this app because it is less cluttered with features I don't use.

@Chesire
Copy link
Owner

Chesire commented Dec 6, 2021

Sounds good, I'll look into a different way to show the sorting window at some point so it would be possible to show the ascending and descending options (#691).
Thanks for this PR 👍

@Chesire Chesire merged commit 5d0cafe into Chesire:master Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants