fix: Refactor WebDAV i18n and UI for improved flexibility and localization #1914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- i18n Updates: - Refactored WebDAV-related translations into nested JSON structures for better organization. - Added support for pluralization in time intervals (minutes and hours) across all locales (en-us, ja-jp, ru-ru, zh-cn, zh-tw). - UI Enhancements: - Updated `DataSettings` and `WebDavSettings` components to use the new i18n keys for time intervals. - Improved the `Select` dropdown for sync intervals with dynamic pluralization based on locale. - Adjusted input field widths for better alignment and consistency. - Code Cleanup: - Removed redundant comments and unused code in `WebDavSettings.tsx`. - Simplified button and input styling for a cleaner layout.
kangfenmao
approved these changes
Feb 18, 2025
这里没有对齐 |
|
看下现在可以不？ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i18n Updates:
UI Enhancements:
DataSettingsandWebDavSettingscomponents to use the new i18n keys for time intervals.Selectdropdown for sync intervals with dynamic pluralization based on locale.Code Cleanup:
WebDavSettings.tsx.