Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong backup check for SQL Always on High availability Groups #643

Closed
wants to merge 21 commits into from
Closed

Fix wrong backup check for SQL Always on High availability Groups #643

wants to merge 21 commits into from

Conversation

fabiozanella
Copy link

@fabiozanella fabiozanella commented Nov 6, 2023

General information

I resume the @marcohald's Bug fix

This commit introduced incompatibility with the standard operation of backups on SQL Always On High availability Groups which involves backups on the secondary replica (see Microsoft resource).

Bug reports

Operating system name and version

SQL Always on High availability Groups on SQL Server 2019
Windows Server 2019

Detailed steps to reproduce the bug

  1. Create a Backup of a High Available Database on Server1
  2. Move the Database to Server2
  3. You get a backup Error because no actual backup is found

Proposed changes

What is the expected behavior?

The Agent should return the Backup status, even if it is not the primary Server

What is the observed behavior?

The Agent does not return the Backup if it is not the Primary Replica

If it's not obvious from the above: In what way does your patch change the current behavior?

The Primary Server check is removed

Is this a new problem? What made you submit this PR (new firmware, new device, changed device behavior)?

The move of the datbase.

List of changes

  • Simplify backup query.
  • Remove the filter to extract backups only from the primary replica.
  • Remove datediff used to trim milliseconds: the convert operation already takes care of this.

Removed the filter to extract backups only from the primary replica.
Removed datediff used to trim milliseconds: the convert operation already takes care of this.
Copy link

github-actions bot commented Nov 6, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@fabiozanella
Copy link
Author

I have read the CLA Document and I hereby sign the CLA or my organization already has a signed CLA.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant