-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wrong backup check for SQL Always on High availability Groups #643
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed the filter to extract backups only from the primary replica. Removed datediff used to trim milliseconds: the convert operation already takes care of this.
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA or my organization already has a signed CLA. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General information
I resume the @marcohald's Bug fix
This commit introduced incompatibility with the standard operation of backups on SQL Always On High availability Groups which involves backups on the secondary replica (see Microsoft resource).
Bug reports
Operating system name and version
SQL Always on High availability Groups on SQL Server 2019
Windows Server 2019
Detailed steps to reproduce the bug
Proposed changes
What is the expected behavior?
The Agent should return the Backup status, even if it is not the primary Server
What is the observed behavior?
The Agent does not return the Backup if it is not the Primary Replica
If it's not obvious from the above: In what way does your patch change the current behavior?
The Primary Server check is removed
Is this a new problem? What made you submit this PR (new firmware, new device, changed device behavior)?
The move of the datbase.
List of changes