Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement service state filter for quicksearch widget #587

Closed
wants to merge 0 commits into from
Closed

Implement service state filter for quicksearch widget #587

wants to merge 0 commits into from

Conversation

moschlar
Copy link
Contributor

@moschlar moschlar commented Mar 31, 2023 •
edited
Loading

General information

I use the quicksearch sidebar widget a lot and I often find myself wanting to see all services matching a description that are not OK - so I thought it would be nice to have an additional filter so that I can query for e.g. s:Certificate st:1 st:2.

Proposed changes

I implemented a ServiceStateMatchPlugin class to accomplish this - it works quite well now!

Open tasks/questions:

  • What is the first element of the return value of get_matches supposed to be?
  • How to correctly display the "preselected" quicksearch filters in the graphical filter selection dialog?

@moschlar moschlar force-pushed the quicksearch-state branch 2 times, most recently from 2ca9074 to 2b91c0e Compare March 31, 2023 08:41
@moschlar moschlar changed the title Try to implement service state filter for quicksearch widget Implement service state filter for quicksearch widget Mar 31, 2023
@moschlar moschlar marked this pull request as ready for review March 31, 2023 08:42
@moschlar moschlar force-pushed the quicksearch-state branch 2 times, most recently from 0a82fc2 to ba87458 Compare March 31, 2023 09:09
@TLI29 TLI29 added enhancement New feature or request Component: GUI labels Apr 4, 2023
@moschlar moschlar force-pushed the quicksearch-state branch 4 times, most recently from 13dcdc9 to 7dd1069 Compare April 28, 2023 06:41
@github-actions
Copy link

github-actions bot commented Apr 28, 2023 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@moschlar
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA or my organization already has a signed CLA.

@moschlar moschlar force-pushed the quicksearch-state branch 4 times, most recently from 488ae6d to 2a4acb9 Compare April 28, 2023 11:33
@moschlar moschlar force-pushed the quicksearch-state branch from 2a4acb9 to 4d509c5 Compare May 26, 2023 08:03
@moschlar
Copy link
Contributor Author

moschlar commented Aug 7, 2023

@Checkmk Ping?

@CheckmkCI CheckmkCI force-pushed the master branch 2 times, most recently from 875a494 to 3419412 Compare May 29, 2024 08:27
@CheckmkCI CheckmkCI closed this Jun 19, 2024
@TimotheusBachinger
Copy link
Contributor

Dear Checkmk Contributor! Unfortunately, we had to re-write our git-repo history, rendering your PR auto-closed. We will therefore rebase your PR onto the current master and reopen it again. Sorry for the inconvenience.

@moschlar
Copy link
Contributor Author

I have just rebased it myself already!

@TimotheusBachinger
Copy link
Contributor

Hi @moschlar thanks for rebasing. However it still seems that your PR has not an up-to-date state (we still see those 10k commits in the header). Maybe you need to update also your PR?

@moschlar
Copy link
Contributor Author

I think I can't do that because it's closed...

But I could just start a new one?

@TimotheusBachinger
Copy link
Contributor

Starting a new one would be an option but we're facing the issue with 52 PRs and all the comments etc would be lost...
I just found this hint, can you try that on your end?
https://gist.github.com/robertpainsi/2c42c15f1ce6dab03a0675348edd4e2c

@moschlar
Copy link
Contributor Author

I tried, but I don't think I have the permission to re-open the PR!

@TimotheusBachinger
Copy link
Contributor

Dear Contributor. Unfortunately, we learned that re-opening a PR which was force-rebased, is not possible (see isaacs/github#361). Therefore we kindly ask you to create a new PR for your change. We apologize for the circumstances and will implement technical measures to prevent such incidents in the future.

@moschlar moschlar mentioned this pull request Jun 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Component: GUI enhancement New feature or request tracked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@moschlar @TimotheusBachinger @TLI29 @CheckmkCI @englertor